There might be some lingering old uses of "xyzcontrol"
instead of "xyzparam", but whatever.

cmHandler ready for cmToStr() and strToCm() functions

- Realised that controller value may get confused with the actual value of the PID terms in the controller. To avoid this confusion in the future I have refactored things referencing the PID constant to now be called "control_parameter"
- There are quite a few instances of variables that changed.
- Sorry Jake

Hopefully there are no copy-paste bugs

- added some comments in commands.c/h about usage of the file
- added a MAX_CONTROLLER_ID and MAX_CONTROL_VAL_ID to the enums in commands.h
- implemented cb_set_control in callbacks.c to work with the new parameter struct
- changes the parameter_struct to now contain an array of pid_controllers instead of a bunch of random PID_t members
- the new parameter_struct array can now be accessed by controller ID as defined in commands.h

Prepared for parsing the new data formats. Data isn't formatted
or parsed yet, though.

No more memory leaks! Unfortunately each memory leak was replaced
by a potential buffer overflow. Basically, the code was riddled
with functions that accept a char ** data, which
is malloced and then formatted. This was then leaked.
Now, it accepts a char * data, which is allocated on the stack
by the calling function. However, there is no bounds checking,
because that is slightly more involved.

See todos in format_command and parse_packet.

added the datatype parameter back into MessageType struct in commands.h because Jake actually does need it.

- removed the "ID", datatype parameters from MessateType struct in commands.h
- made equivalent changes in commands.c

- removed every use of the "subtype" term
- made the "type" term 16 bits
- made sure that every reference to a message type is 16 bits and used correctly
- simplified commands enum names
- implemented setcontrol callback function that switch on the controller and P, I, D, setpoint value to be set and then set them
- partly implemented getcontrol callback function
- NOTE: setpoint is a double. this causes some problems..
- TODO: add setpoints for rate controllers
- TODO: figure out what message ID I should send back when I get a getpid command

- Added a comment saying that we may not need the ID parameter on the MessageType Struct anymore.
- Removed calls of the nature: "MessageTypes[TYPE_ID].ID" and replaced them with "TYPE_ID" because it is the same thing..
- Added function comments in callbacks.c
- Simplified the callbacks.c by having a more generic setval, getval, respval callback function instead of a billion of them for each PID value.

also added some more comments in both files

jpbush authored 8 years ago and dawehr committed 8 years ago

also reorganized the ordering of the commands in commands.c
added a enum for message types and subtype but this will get removed on the next commit

latitude functions are now y, and longitude functions are now x instead. 
I also recognize that setting an actual lat, lon set point in the future may be useful so I have retained those functions.