Skip to content
Snippets Groups Projects
Unverified Commit f492b4d3 authored by Jake Drahos's avatar Jake Drahos
Browse files

Made logger a little bit more palatable

- Thread safety
- Some unignorable fixes in the filename creation.
  - That part is still terribad
parent 19fdee13
No related branches found
No related tags found
No related merge requests found
...@@ -38,4 +38,5 @@ src/vrpn/build* ...@@ -38,4 +38,5 @@ src/vrpn/build*
src/vrpn/pc_linux64/* src/vrpn/pc_linux64/*
#Exacutables #Exacutables
./BlueTooth BlueTooth
logs
...@@ -4,21 +4,30 @@ ...@@ -4,21 +4,30 @@
*/ */
#include "logger.h" #include "logger.h"
#include <stdio.h> #include <stdio.h>
#include <err.h>
#include <pthread.h>
int quadlog_file; static FILE * quadlog_file = NULL;
static pthread_mutex_t mutex = PTHREAD_MUTEX_INITIALIZER;
int createLogFile(int argc, char* argv) int createLogFile(int argc, char* argv)
{ {
char log_file[300] = {'l', 'o', 'g','s', '/'}; if (quadlog_file != NULL) {
return -1;
}
if (pthread_mutex_lock(&mutex)) {
err(-2, "pthrtead_mutex_lock (%s:%d):", __FILE__, __LINE__);
}
char log_file[300];
strcpy(log_file, "logs/");
if(argc >= 2) if(argc >= 2)
{ {
strcat(log_file, argv); strncat(log_file, argv, 294);
printf("Creating log file '%s'...\n",log_file); printf("Creating log file '%s'...\n",log_file);
quadlog_file = open(log_file, O_WRONLY | O_CREAT, 0666); quadlog_file = fopen(log_file, "a");
return quadlog_file; } else {
}
else
{
time_t rawtime; time_t rawtime;
char timestr [30]; char timestr [30];
time(&rawtime); time(&rawtime);
...@@ -26,7 +35,7 @@ int createLogFile(int argc, char* argv) ...@@ -26,7 +35,7 @@ int createLogFile(int argc, char* argv)
// Lets convert space to _ in // Lets convert space to _ in
char *p = timestr; char *p = timestr;
int i = 0; size_t i = 0;
while(i < strlen(timestr)) while(i < strlen(timestr))
{ {
if (*p == ' ') if (*p == ' ')
...@@ -40,18 +49,60 @@ int createLogFile(int argc, char* argv) ...@@ -40,18 +49,60 @@ int createLogFile(int argc, char* argv)
strncat(log_file, timestr, strlen(timestr) -1 ); strncat(log_file, timestr, strlen(timestr) -1 );
strcat(log_file, ".txt"); strcat(log_file, ".txt");
printf("Creating log file '%s'...\n",log_file); printf("Creating log file '%s'...\n",log_file);
quadlog_file = open(log_file, O_WRONLY | O_CREAT, 0666); quadlog_file = fopen(log_file, "a");
return quadlog_file; }
if (pthread_mutex_unlock(&mutex)) {
err(-2, "pthrtead_mutex_unlock (%s:%d):", __FILE__, __LINE__);
} }
return 0;
} }
int updateLogFile(const struct ucart_vrpn_TrackerData * td) int updateLogFile(const struct ucart_vrpn_TrackerData * td)
{ {
return dprintf(quadlog_file, "FPS: %lf Pos (xyz): (%lf %lf %lf) Att (pry): (%lf %lf %lf)\n", int retval;
if (pthread_mutex_lock(&mutex)) {
err(-2, "pthrtead_mutex_lock (%s:%d):", __FILE__, __LINE__);
}
retval = fprintf(quadlog_file,
"FPS: %lf Pos (xyz): (%lf %lf %lf) Att (pry): (%lf %lf %lf)\n",
td->fps, td->x, td->y, td->z, td->pitch, td->roll, td->yaw); td->fps, td->x, td->y, td->z, td->pitch, td->roll, td->yaw);
if (pthread_mutex_unlock(&mutex)) {
err(-2, "pthrtead_mutex_unlock (%s:%d):", __FILE__, __LINE__);
}
return retval;
} }
int writeStringToLog(const char * string) int writeStringToLog(const char * string)
{ {
return dprintf(quadlog_file, "%s", string); int retval;
if (pthread_mutex_lock(&mutex)) {
err(-2, "pthrtead_mutex_lock (%s:%d):", __FILE__, __LINE__);
}
retval = fprintf(quadlog_file, "%s", string);
if (pthread_mutex_unlock(&mutex)) {
err(-2, "pthrtead_mutex_unlock (%s:%d):", __FILE__, __LINE__);
}
return retval;
}
void closeLogFile(void)
{
if (pthread_mutex_lock(&mutex)) {
err(-2, "pthrtead_mutex_lock (%s:%d):", __FILE__, __LINE__);
}
fclose(quadlog_file);
if (pthread_mutex_unlock(&mutex)) {
err(-2, "pthrtead_mutex_unlock (%s:%d):", __FILE__, __LINE__);
}
} }
...@@ -15,6 +15,7 @@ ...@@ -15,6 +15,7 @@
int createLogFile(int, char*); int createLogFile(int, char*);
int writeStringToLog(const char*); int writeStringToLog(const char*);
int updateLogFile(const struct ucart_vrpn_TrackerData* ); int updateLogFile(const struct ucart_vrpn_TrackerData* );
void closeLogFile();
#endif #endif
\ No newline at end of file
...@@ -43,6 +43,11 @@ int safe_fd_clr(int , fd_set* , int* ); ...@@ -43,6 +43,11 @@ int safe_fd_clr(int , fd_set* , int* );
static void cb(struct ucart_vrpn_TrackerData *); static void cb(struct ucart_vrpn_TrackerData *);
/* Thread-safe wrappers */
pthread_mutex_t quadSocketMutex, logFileMutex;
ssize_t writeQuad(const char * buf, size_t count);
ssize_t dprintfLog(const char * fmt, ...);
// global variables // global variables
static volatile int keepRunning = 1; static volatile int keepRunning = 1;
const char *TRACKER_IP = "UAV@192.168.0.120:3883"; const char *TRACKER_IP = "UAV@192.168.0.120:3883";
...@@ -329,4 +334,4 @@ int safe_fd_clr(int fd, fd_set* fds, int* max_fd) { ...@@ -329,4 +334,4 @@ int safe_fd_clr(int fd, fd_set* fds, int* max_fd) {
(*max_fd)--; (*max_fd)--;
} }
return 0; return 0;
} }
\ No newline at end of file
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment